Draft
Conversation
Contributor
🧪 Java Unit Tests
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
@fdelbrayelle, the bump in this PR wont work since we are using Do you know any alternatives? |
Member
|
@Malaydewangan09 Try this one instead: https://github.com/hierynomus/smbj and remove jcifs it's only old unsecure SMB1 and not maintained for more than 3 years |
f0faabe to
1d7b9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are being made and why?
How the changes have been QAed?
Setup Instructions
Contributor Checklist ✅
closes #ISSUE_IDorfixes #ISSUE_IDin the description if the PR relates to an opened issue.@Schemafor properties and outputs,@Pluginwith examples,README.mdfile with basic knowledge and specifics).rnotrendered(eg:rHost).runContext.logger()to log enough important infos where it's needed and with the best level (DEBUG, INFO, WARN or ERROR).⚙️ Properties
Property<T>carrier type, do not use@PluginProperty.@NotNulland checked during the rendering.Property<Map<String, Object>>.🌐 HTTP
io.kestra.core.http.client📦 JSON
@JsonIgnoreProperties(ignoreUnknown = true)at the mapped class level. So that we will avoid to crash the plugin if the provider add a new field suddenly.io.kestra.core.serializers)✨ New plugins / subplugins
package-info.javaunder each sub package respecting this format and choosing the right category.src/main/resources/iconsin SVG format and not in thumbnail (keep it big):plugin-icon.svgio.kestra.plugin.aws.svgio.kestra.plugin.aws.s3, addio.kestra.plugin.aws.s3.svgSee example here.
"{{ secret('YOUR_SECRET') }}"in the examples for sensible infos such as an API KEY.Property<FetchType> fetchTypeto be able to useFETCH_ONE,FETCHand evenSTOREto store big amount of data in the internal storage."""to close examples blocks with the flow id.🧪 Tests
RunContextto actually run tasks).src/test/resources/flows..github/setup-unit.sh(which can be executed locally and in the CI) all along with a newdocker-compose-ci.ymlfile (do not edit the existingdocker-compose.yml).📤 Outputs
VoidOutput.